Widen Node versions to test against - #94
Open
GCHQDeveloper581 wants to merge 4 commits into
Open
GCHQDeveloper581 wants to merge 4 commits into
GCHQDeveloper581 wants to merge 4 commits into
Conversation
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
This matrix is not reproducible because postinstall installs an unpinned cyberchef with --no-save, so each CI rerun can test a different dependency/runtime contract. The currently published CyberChef 11.4.0 requires Node >=24 <27, while this PR retains Node 18/20 as compatibility legs. Could we pin the CyberChef version used by the matrix (or derive the Node matrix from its declared engines) so the results represent supported, repeatable combinations?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.